Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Use portable !, not GNUish -not, with find(1). #24565

Merged

Conversation

riastradh
Copy link
Contributor

fix #24564

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 6, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 6, 2023
@riastradh riastradh changed the title Makefile: Use portable !', not GNUish -not', with find(1). Makefile: Use portable !, not GNUish -not, with find(1). May 6, 2023
@riastradh riastradh changed the title Makefile: Use portable !, not GNUish -not, with find(1). Makefile: Use portable !, not GNUish -not, with find(1). May 6, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 6, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 6, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 6, 2023
@delvh
Copy link
Member

delvh commented May 6, 2023

Should we backport this change?

@lunny lunny added the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label May 6, 2023
@lunny lunny added this to the 1.20.0 milestone May 6, 2023
@lunny lunny merged commit 377e013 into go-gitea:main May 7, 2023
14 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 7, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 7, 2023
)

fix go-gitea#24564

Co-authored-by: Taylor R Campbell <campbell+gitea@mumble.net>
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label May 7, 2023
lunny pushed a commit that referenced this pull request May 7, 2023
…4572)

Backport #24565 by @riastradh

fix #24564

Co-authored-by: Taylor R Campbell <campbell+gitea@mumble.net>
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 8, 2023
* upstream/main:
  Fix broken link in tests/e2e/README (go-gitea#24576)
  [skip ci] Updated licenses and gitignores
  Add goto issue id function (go-gitea#24479)
  Improve decryption failure message (go-gitea#24573)
  Simplify template helper functions (go-gitea#24570)
  Makefile: Use portable !, not GNUish -not, with find(1). (go-gitea#24565)
  Add org visibility label to non-organization's dashboard (go-gitea#24558)
  Sort users and orgs on explore by recency by default (go-gitea#24279)
  Change `add_on` translation to `added_on` and include placeholder for the date (go-gitea#24562)
  Change `valid_until` translation to `valid_until_date` and include placeholder for the date (go-gitea#24563)
  Fix docs failing the build on `main` (go-gitea#24561)
  Improve wiki user title test (go-gitea#24559)
  Fix incorrect user visibility (go-gitea#24557)
  Change `join_on` translation to `joined_on` and include placeholder for the date (go-gitea#24550)
  Require at least one unit to be enabled (go-gitea#24189)
  Fix broken `README` link (go-gitea#24546)
  Check latest version on CI (go-gitea#24556)
@yardenshoham yardenshoham added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 8, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Makefile invokes find with nonportable, non-POSIX -not option
6 participants