Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve "goto issue by number" button #24577

Merged
merged 10 commits into from
May 10, 2023
Merged

Improve "goto issue by number" button #24577

merged 10 commits into from
May 10, 2023

Conversation

wxiaoguang
Copy link
Contributor

Follow #24479

image

image

image

image

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 7, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 7, 2023
@wxiaoguang wxiaoguang mentioned this pull request May 7, 2023
Merged
@wxiaoguang wxiaoguang force-pushed the improve-goto-issue branch 3 times, most recently from 280ea08 to 271b129 Compare May 7, 2023 18:13
@wxiaoguang wxiaoguang added this to the 1.20.0 milestone May 7, 2023
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 7, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 8, 2023
@wxiaoguang wxiaoguang requested a review from delvh May 8, 2023 14:51
silverwind
silverwind reviewed May 8, 2023
View reviewed changes
web_src/js/utils/dom.js Outdated Show resolved Hide resolved
@silverwind
Copy link
Member

silverwind commented May 8, 2023 •
edited
Loading

Might be a good idea to convert common-issue-list.js from jQuery to vanilla, but maybe for later. I don't like new features using jQuery.

wxiaoguang and others added 2 commits May 9, 2023 09:41
@wxiaoguang @silverwind
Update web_src/js/utils/dom.js
c5c3386 
Co-authored-by: silverwind <me@silverwind.io>
@wxiaoguang @silverwind
Update web_src/js/features/common-issue-list.js
16777fd 
Co-authored-by: silverwind <me@silverwind.io>
@wxiaoguang
Copy link
Contributor Author

Might be a good idea to convert common-issue-list.js from jQuery to vanilla, but maybe for later. I don't like new features using jQuery.

That's what I have asked before:

Next time , a jQuery (or more general, non-ideal) PR comes, what should be done?

  • Keep asking the contributor rewriting? Is it friendly?
  • Keep it stale?
  • Maintainers help to rewrite a lot PRs, like what I did before but now I haven't applied writer permission.

@wxiaoguang
Merge branch 'main' into improve-goto-issue
d72af39 
# Conflicts:
#	web_src/js/features/repo-issue.js
@silverwind
Copy link
Member

Keep asking the contributor rewriting? Is it friendly?

Depends on size I guess. Sub 20 line numbers, I would definitely recommend the author to ask to re-write if they can, but of course not blocking on it. jQuery stuff can be gradually forbidden with eslint rules, and at some point it will just become impractical to use jQuery at all with all its features disabled.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 10, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 10, 2023
@silverwind silverwind enabled auto-merge (squash) May 10, 2023 15:39
@silverwind silverwind merged commit 23ae939 into go-gitea:main May 10, 2023
14 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 10, 2023
@wxiaoguang wxiaoguang deleted the improve-goto-issue branch May 10, 2023 15:51
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 11, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
cb2de12 
* upstream/main:
  Fix typo in act-runner file (go-gitea#24652)
  RSS icon fixes (go-gitea#24476)
  Notification list enhancements, fix striped tables on dark theme (go-gitea#24639)
  Improve "goto issue by number" button (go-gitea#24577)
  Increase default LFS auth timeout from 20m to 24h (go-gitea#24628)
  Fix typo in the swift package documentation (go-gitea#24637)
  Fix broken links in documents (go-gitea#24630)
  Improve updating Actions tasks (go-gitea#24600)
  Modify luminance calculation and extract related functions into single files (go-gitea#24586)
  Do not send "registration success email" for external auth sources (go-gitea#24632)
  Fix typo in Actions demo file (go-gitea#24631)
  Review fixes and enhancements (go-gitea#24526)
  Remove fluid on compare diff page (go-gitea#24627)
  Make the actions control button look like an actual button (go-gitea#24611)
  Add a tooltip to the job rerun button (go-gitea#24617)
  Improve reverse-proxy document and fix nginx config bug (go-gitea#24616)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

@delvh delvh Awaiting requested review from delvh

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wxiaoguang @silverwind @lunny @GiteaBot