Branches management UI #2464
Closed
Branches management UI #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/feature
lafriks
reviewed
Sep 5, 2017
| @@ -579,6 +579,14 @@ func RegisterRoutes(m *macaron.Macaron) { | |||
| m.Get("/milestones", repo.Milestones) | |||
| }, context.RepoRef()) | |||
|
|
|||
| m.Group("/branches", func() { | |||
There was a problem hiding this comment.
I think this group needs context.CheckUnit(models.UnitTypeCode)
ethantkoenig
suggested changes
Sep 5, 2017
routers/repo/branch.go
Outdated
|
|
||
| brs, err := ctx.Repo.GitRepo.GetBranches() | ||
| func loadBranches(c *context.Context) []*Branch { |
There was a problem hiding this comment.
Could we name it ctx for consistency with other handlers? Likewise in other places
routers/routes/routes.go
Outdated
| m.Get("/all", repo.AllBranches) | ||
| m.Post("/delete/*", reqSignIn, reqRepoWriter, repo.DeleteBranchPost) | ||
| }, repo.MustBeNotBare, func(c *context.Context) { | ||
| c.Data["PageIsViewFiles"] = true |
There was a problem hiding this comment.
Is "PageIsViewFiles" used anywhere? I can't find it anywhere in this PR or in existing code.
routers/repo/branch.go
Outdated
|
|
||
| protectBranches, err := c.Repo.Repository.GetProtectedBranches() | ||
| if err != nil { | ||
| c.Handle(500, "GetProtectBranchesByRepoID", err) |
|
@ethantkoenig all done. |
tboerger
added
the
lgtm/need 2
lunny
force-pushed
the
lunny/branches_status_bar
branch
from
32b781c
to
bce3545
Compare
appleboy
approved these changes
Sep 5, 2017
lunny
force-pushed
the
lunny/branches_status_bar
branch
from
bce3545
to
b0e1124
Compare
ethantkoenig
approved these changes
Sep 11, 2017
|
Would be nice to provide screenshots, otherwise LGTM |
tboerger
added
lgtm/need 1
|
I am for adding some example screenshots too. |
|
Just found a bug |
|
seems this is duplicated with #2108 |
|
Yes these PR need to be merged in one :) |
|
#2108 will replace this one, so I close here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. This should be the first step to move
commits, branches, tagsas a submenu of Code.