Hotfix for integration testing #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
1 similar comment
|
LGTM |
tboerger
added
the
lgtm/done
|
But CI failed? |
appleboy
approved these changes
Sep 8, 2017
|
True, but I don't understand why this fails... |
jonasfranz
approved these changes
Sep 8, 2017
Morlinest
reviewed
Sep 8, 2017
| @@ -3,7 +3,7 @@ RUN_MODE = prod | |||
|
|
|||
| [database] | |||
| DB_TYPE = mysql | |||
| HOST = 127.0.0.1:3306 | |||
| HOST = mysql:3306 | |||
There was a problem hiding this comment.
This is not general, just for drone. We will not be able to run tests on local env (without modifying host). Same for pgsql.
There was a problem hiding this comment.
We will focus on ci integration for sure
There was a problem hiding this comment.
but could we run the test locally?
There was a problem hiding this comment.
Only if the value can be provided via some environment variable. But beside that you can also run drone exec locally.
|
I think we can merge this PR. Since it fix database access. For the rest, it maybe the deployment of the integration env that take to much time and is not ready for testing when it start in some conditions. |
sapk
approved these changes
Sep 9, 2017
lafriks
pushed a commit
to ethantkoenig/gitea
that referenced
this pull request
Sep 20, 2017
* Hotfix for integration testing * Comment sqlite tests because of database locking issues
lafriks
pushed a commit
that referenced
this pull request
Sep 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.