Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix topics deleted via API not being deleted in org page #24825

Merged
merged 3 commits into from
May 21, 2023
Merged

Fix topics deleted via API not being deleted in org page #24825

merged 3 commits into from
May 21, 2023

Commits on May 20, 2023

  1. Fix topics deleted via API not being deleted in org page 

    The topics are saved in the repo_topic table with a repoID key. They are also saved directly in the repository table.

Before this PR, only `AddTopic` and `SaveTopics` made sure the `topics` field in the repository field was synced with the repo_topic table.

This PR makes sure `GenerateTopics` and `DeleteTopic` also sync the `topics` in the repository table.

`RemoveTopicsFromRepo` doesn't need to sync the data as it is only used to delete a repository.
    @yardenshoham
    yardenshoham committed May 20, 2023
    Configuration menu
    Copy the full SHA
    6d8f53b View commit details
    Browse the repository at this point in the history

  2. Simplify

    @yardenshoham
    yardenshoham committed May 20, 2023
    Configuration menu
    Copy the full SHA
    405a42e View commit details
    Browse the repository at this point in the history

Commits on May 21, 2023

  1. Merge branch 'main' into issues/24820

    @GiteaBot
    GiteaBot committed May 21, 2023
    Configuration menu
    Copy the full SHA
    75b9221 View commit details
    Browse the repository at this point in the history