Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change --font-weight-bold to --font-weight-semibold and 600 value, introduce new font weight variables" #24852

Closed
wants to merge 1 commit into from

Conversation

lunny
Copy link
Member

@lunny lunny commented May 22, 2023

Reverts #24827
Fix #24850
@silverwind

…00 value, introduce new font weight variables (#24827)"

This reverts commit 19993d8.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 22, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 22, 2023
@lunny lunny added the issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself label May 22, 2023
@silverwind
Copy link
Member

silverwind commented May 22, 2023

Don't revert the whole thing, just set it to --font-weight-light here:

font-weight: var(--font-weight-normal);

Thought I do think 400 is slightly preferred for english fonts at least as it matches GitHub, but I have no strong preference, so am fine with 300 too. I think there are some mechanisms to make asian fonts appear less bold, maybe we can use it there if it only affects asian fonts?

@lunny
Copy link
Member Author

lunny commented May 22, 2023

Don't revert the whole thing, just set it to --font-weight-light here:

font-weight: var(--font-weight-normal);

Thought I do think 400 is slightly preferred for english fonts at least as it matches GitHub, but I have no strong preference, so am fine with 300 too. I think there are some mechanisms to make asian fonts appear less bold, maybe we can use it there if it only affects asian fonts?

Could you send a PR to fix that?

@lunny lunny closed this May 22, 2023
@lunny lunny deleted the revert-24827-font-600 branch May 22, 2023 08:23
@silverwind
Copy link
Member

Maybe. Do you think 400 is ok for english text, and the boldness issue is only on asian fonts?

@silverwind
Copy link
Member

#24855

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue title bold becomes weight
3 participants