Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated rel attribute #2549

Merged
merged 3 commits into from
Sep 20, 2017
Merged

Conversation

jorgesumle
Copy link
Contributor

According to the HTML 5.1 recommendation "The rel attribute on a
and area elements controls what kinds of links the elements create.
The attribute’s value must be a set of space-separated tokens. [emphasis added]"
(source https://www.w3.org/TR/html51/links.html#links-created-by-a-and-area-elements).

According to the HTML 5.1 recommendation "The rel attribute on a
and area elements controls what kinds of links the elements create.
The attribute’s value must be a set of space-separated tokens."
(source https://www.w3.org/TR/html51/links.html#links-created-by-a-and-area-elements)
@lunny lunny added the type/enhancement An improvement of existing functionality label Sep 19, 2017
@lunny lunny added this to the 1.x.x milestone Sep 19, 2017
@lafriks
Copy link
Member

lafriks commented Sep 19, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 19, 2017
@bkcsoft
Copy link
Member

bkcsoft commented Sep 19, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 19, 2017
@codecov-io
Copy link

codecov-io commented Sep 20, 2017

Codecov Report

Merging #2549 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2549   +/-   ##
=======================================
  Coverage   27.21%   27.21%           
=======================================
  Files          85       85           
  Lines       16955    16955           
=======================================
  Hits         4615     4615           
  Misses      11665    11665           
  Partials      675      675

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acecedc...2dccb03. Read the comment docs.

@lunny lunny modified the milestones: 1.x.x, 1.3.0 Sep 20, 2017
@lafriks lafriks merged commit 8b6236d into go-gitea:master Sep 20, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants