Fix CLI sub-command handling #25501
Merged
Fix CLI sub-command handling #25501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
wxiaoguang
added
type/bug
backport/v1.20
pull-request-size
bot
added
size/S
delvh
approved these changes
Jun 25, 2023
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Jun 26, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jun 26, 2023
A regression of go-gitea#25330 : The nil "Action" should be treated as "help" In old releases: `./gitea admin` show helps After go-gitea#25330: `./gitea admin` panics (although the code returned `nil` if action is nil, but Golang's quirk is: nil in interface is not nil) With this PR: `./gitea admin` shows helps as the old releases.
GiteaBot
added
backport/done
lunny
pushed a commit
that referenced
this pull request
Jun 26, 2023
Backport #25501 by @wxiaoguang A regression of #25330 : The nil "Action" should be treated as "help" In old releases: `./gitea admin` show helps After #25330: `./gitea admin` panics (although the code returned `nil` if action is nil, but Golang's quirk is: nil in interface is not nil) With this PR: `./gitea admin` shows helps as the old releases. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression of #25330 : The nil "Action" should be treated as "help"
In old releases:
./gitea adminshow helpsAfter #25330:
./gitea adminpanics (although the code returnednilif action is nil, but Golang's quirk is: nil in interface is not nil)With this PR:
./gitea adminshows helps as the old releases.