Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display branch commit status #25608

Merged
merged 9 commits into from Jul 3, 2023
Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 30, 2023

Fix #10388

This PR adds a status icon for every branch which has a status check for the latest commit on branch list page.

图片

@lunny lunny added the type/enhancement An improvement of existing functionality label Jun 30, 2023
@lunny lunny added this to the 1.21.0 milestone Jun 30, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 30, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 30, 2023
@silverwind
Copy link
Member

silverwind commented Jul 1, 2023

Separare column in the UI may be nice, but this table needs to be rewritten later, so I guess this position is ok until then.

@denyskon
Copy link
Member

denyskon commented Jul 1, 2023

Separare column in the UI may be nice, but this table needs to be rewritten later, so I guess this position is ok until then.

That's the way we do it on commits list, so I also think we can stay with it for now.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 1, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 1, 2023
@yardenshoham
Copy link
Member

I'd call this a feature

@delvh delvh added type/feature Completely new functionality. Can only be merged if feature freeze is not active. and removed type/enhancement An improvement of existing functionality labels Jul 1, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 2, 2023
@lunny lunny enabled auto-merge (squash) July 3, 2023 00:52
@lunny lunny merged commit 7735da1 into go-gitea:main Jul 3, 2023
24 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 3, 2023
Comment on lines +361 to +363
conds := make([]builder.Cond, 0, len(commitIDs))
for _, sha := range commitIDs {
conds = append(conds, builder.Eq{"sha": sha})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that a builder.In?

@lunny lunny deleted the lunny/branch_commit_status branch August 24, 2023 12:42
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display commit status on branches list page.
6 participants