some less naked returns #25682
Merged
some less naked returns #25682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
This was referenced Jul 4, 2023
wxiaoguang
approved these changes
Jul 4, 2023
GiteaBot
added
lgtm/need 1
|
Is it all? I think there were like 50+ errors. |
6543
commented
Jul 4, 2023
6543
commented
Jul 4, 2023
just fixed the one from your pull report ... I'll update the toolink up ahead and check again |
|
well let's merge this ... but yes there are way more |
delvh
approved these changes
Jul 4, 2023
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
|
Yeah, let's see if that is enough to get the PR green. Otherwise, I could invite you to my fork so you can push directly to the branch. |
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 5, 2023
* giteaofficial/main: (22 commits)
[skip ci] Updated translations via Crowdin
Replace `interface{}` with `any` (go-gitea#25686)
Several fixes for mobile UI (go-gitea#25634)
Add elapsed time on debug for slow git commands (go-gitea#25642)
some less naked returns (go-gitea#25682)
Prevent duplicate image loading (go-gitea#25675)
Add unit test for `HashAvatar` (go-gitea#25662)
Fix the nil pointer when assigning issues to projects (go-gitea#25665)
Actions list enhancements (go-gitea#25601)
Fix issues indexer document mapping (go-gitea#25619)
Fix show more for image on diff page (go-gitea#25672)
Prevent SVG shrinking (go-gitea#25652)
Log the real reason when authentication fails (but don't show the user) (go-gitea#25414)
Add unit test for repository collaboration (go-gitea#25640)
Fix UI misalignment on user setting page (go-gitea#25629)
[skip ci] Updated translations via Crowdin
Correct translation wrong format (go-gitea#25643)
Add direct serving of package content (go-gitea#25543)
Fix bug when change user name (go-gitea#25637)
Make "cancel" buttons have proper type in modal forms (go-gitea#25618)
...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix upcoming lint issues