Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test if container blob is accessible before mounting (#22759) #25783

Merged
merged 1 commit into from
Jul 9, 2023
Merged

Test if container blob is accessible before mounting (#22759) #25783

merged 1 commit into from
Jul 9, 2023

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Jul 9, 2023

Backport #22759 by @KN4CK3R

related #16865

This PR adds an accessibility check before mounting container blobs.

@KN4CK3R @techknowlogick
@silverwind @GiteaBot
Test if container blob is accessible before mounting (go-gitea#22759)
bdedc3f 
related go-gitea#16865

This PR adds an accessibility check before mounting container blobs.

---------

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: silverwind <me@silverwind.io>
@GiteaBot GiteaBot added topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! topic/packages labels Jul 9, 2023
@GiteaBot GiteaBot added this to the 1.19.5 milestone Jul 9, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 9, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 9, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 9, 2023
@silverwind silverwind enabled auto-merge (squash) July 9, 2023 11:42
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 9, 2023
@silverwind silverwind merged commit 5bfe469 into go-gitea:release/v1.19 Jul 9, 2023
2 checks passed
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Jul 12, 2023
@GiteaBot @earl-warren
Test if container blob is accessible before mounting (go-gitea#22759) (…
28ab56b 
…go-gitea#25783)

Backport go-gitea#22759 by @KN4CK3R

related go-gitea#16865

This PR adds an accessibility check before mounting container blobs.

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: silverwind <me@silverwind.io>
(cherry picked from commit 5bfe469)
@techknowlogick techknowlogick deleted the backport-22759-v1.19 branch September 9, 2023 05:29
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@delvh delvh Awaiting requested review from delvh

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

Assignees

@KN4CK3R KN4CK3R

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/packages topic/security Something leaks user information or is otherwise vulnerable. Should be fixed!
Projects
None yet
Milestone
1.19.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GiteaBot @silverwind @KN4CK3R