Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore runs-on with expressions when warning no matched runners (#25917) #25933

Merged
merged 2 commits into from Jul 18, 2023
Merged

Ignore runs-on with expressions when warning no matched runners (#25917) #25933

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0c9694
Ignore `runs-on` with expressions when warning no matched runners (#2…
wolfogre Jul 17, 2023
ed921bf
Merge branch 'release/v1.20' into backport-25917-v1.20
GiteaBot Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions routers/web/repo/actions/actions.go
View file
Open in desktop
Expand Up @@ -6,6 +6,7 @@ package actions
import (
"bytes"
"net/http"
"strings"

actions_model "code.gitea.io/gitea/models/actions"
"code.gitea.io/gitea/models/db"
Expand Down Expand Up @@ -105,6 +106,12 @@ func List(ctx *context.Context) {
for _, j := range wf.Jobs {
runsOnList := j.RunsOn()
for _, ro := range runsOnList {
if strings.Contains(ro, "${{") {
// Skip if it contains expressions.
// The expressions could be very complex and could not be evaluated here,
// so just skip it, it's OK since it's just a tooltip message.
continue
}
if !allRunnerLabels.Contains(ro) {
workflow.ErrMsg = ctx.Locale.Tr("actions.runs.no_matching_runner_helper", ro)
break
Expand Down