Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pending commit status yellow again (#25935) #25968

Merged
merged 2 commits into from Jul 19, 2023
Merged

Make pending commit status yellow again (#25935) #25968

merged 2 commits into from Jul 19, 2023

Commits on Jul 18, 2023

  1. Make pending commit status yellow again (go-gitea#25935) 

    With the introduction of Actions, the pending commit icon has changed
from yellow to grey for Drone integrations which never set the "running"
status, so it stays in "pending" until completion.

I find it better to have this icon colored like on 1.19. Now both the
"pending" and "running" icons look the same, but I guess we could add an
animation to the "running" state similar to GitHub has to it later.

Before:
<img width="339" alt="Screenshot 2023-07-17 at 19 14 19"
src="https://github.com/go-gitea/gitea/assets/115237/2f4886e4-74fd-42ea-b59e-9af8f141bf1f">

After:
<img width="335" alt="Screenshot 2023-07-17 at 19 14 30"
src="https://github.com/go-gitea/gitea/assets/115237/53189642-e72d-47f6-9cbe-f14eda28f730">

Also, it matches GH's icon:

<img width="466" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/5804ff90-d223-4a3c-8093-7a9abbaacf87">

---------

Co-authored-by: delvh <dev.lh@web.de>
    @silverwind @delvh @GiteaBot
    2 people authored and GiteaBot committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    38eb7e5 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Merge branch 'release/v1.20' into backport-25935-v1.20

    @GiteaBot
    GiteaBot committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    17b849e View commit details
    Browse the repository at this point in the history