PATCH branch-protection updates check list even when checks are disabled #26351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
… are disabled Fixes: go-gitea#26333
lunny
added
modifies/api
lunny
approved these changes
Aug 24, 2023
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Aug 24, 2023
lunny
added
the
reviewed/wait-merge
GiteaBot
added
lgtm/done
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 25, 2023
* giteaofficial/main: Fix review bar misalignment (go-gitea#26711) Use "small-loading-icon" insead of "btn-octicon is-loading" (go-gitea#26710) Improve Image Diff UI (go-gitea#26696) Make issue template field template access correct template data (go-gitea#26698) add Upload URL to release API (go-gitea#26663) Add merge files files to GetCommitFileStatus (go-gitea#20515) PATCH branch-protection updates check list even when checks are disabled (go-gitea#26351) Add `member`, `collaborator`, `contributor`, and `first-time contributor` roles and tooltips (go-gitea#26658) chore(actions): support cron schedule task (go-gitea#26655)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #26333.
Previously, this endpoint only updates the
StatusCheckContextsfield whenEnableStatusCheck==true, which makes it impossible to clear the array otherwise.This patch uses slice
nil-ness to decide whether to update the list of checks. The field is ignored when either the client explicitly passes in a null, or just omits the field from the json (which causesjson.Unmarshalto leave the struct field unchanged). I think this is a better measure of intent than whether theEnableStatusCheckflag was set, because it matches the semantics of other field types.Also adds a test case. I noticed that
testAPIEditBranchProtectiononly checks the branch name and no other fields, so I added some extraGETcalls and specific checks to make sure the fields are changing properly.I added those checks the existing integration test; is that the right place for it?