Improve tree not found page #26570
Merged
Improve tree not found page #26570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
wxiaoguang
reviewed
Aug 18, 2023
There was a problem hiding this comment.
- bugs:
{{.locale.Tr "repo.tree_not_found" .BranchName .RepoName .TreePath | Safe}}=> XSS - design: I do not think it's maintainable to fill the "404.tmpl" with more and more
ifblocks. IMO either:- Use a dedicate page for "tree path not found"
- Use a general approach for 404 page, eg: "NotFoundPrompt" + "NotFoundGoBackURL"
wxiaoguang
reviewed
Aug 18, 2023
wxiaoguang
reviewed
Aug 18, 2023
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
yp05327
force-pushed
the
improve-tree-not-found
branch
from
e401506
to
4f10f70
Compare
wxiaoguang
reviewed
Aug 18, 2023
wxiaoguang
approved these changes
Aug 18, 2023
GiteaBot
added
lgtm/need 1
yp05327
commented
Aug 18, 2023
|
Agree to a dedicated rendering without the big 404. Maybe just conditionally remove the logo in such a case. |
pull-request-size
bot
added
size/M
wxiaoguang
reviewed
Aug 21, 2023
wxiaoguang
approved these changes
Aug 22, 2023
lunny
added
the
topic/ui-interaction
delvh
previously requested changes
Sep 17, 2023
GiteaBot
added
lgtm/blocked
yp05327
commented
Sep 28, 2023
routers/web/repo/helper.go
Outdated
Comment on lines
29
to
38
| refType := "" | ||
| switch { | ||
| case ctx.Repo.IsViewBranch: | ||
| refType = "branch" | ||
| case ctx.Repo.IsViewTag: | ||
| refType = "tag" | ||
| case ctx.Repo.IsViewCommit: | ||
| refType = "commit" | ||
| } | ||
| ctx.Data["NotFoundPrompt"] = ctx.Locale.Tr("repo.tree_path_not_found_" + refType, ctx.Repo.TreePath, url.PathEscape(ctx.Repo.RefName)) |
There was a problem hiding this comment.
@delvh
There's a risk when refType is empty? I'm not sure what will happen when the key word not exists.
There was a problem hiding this comment.
Well, in that case, the user will see the message repo.tree_path_not_found_ instead of Path <path> is not contained within <type> <name>.
In which case, we then know that we need to adapt this switch…
There was a problem hiding this comment.
But I don't even know how a user would trigger something like that.
What other ref types are there except branches, commits, and tags?
delvh
approved these changes
Sep 28, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Sep 29, 2023
Before:  After:  In Github: https://github.com/yp05327/test/blob/main/test.drawio Updated: UI changed   --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
GiteaBot
added
backport/done
lunny
added a commit
that referenced
this pull request
Sep 29, 2023
Backport #26570 by @yp05327 Before:  After:  In Github: https://github.com/yp05327/test/blob/main/test.drawio Updated: UI changed   Co-authored-by: yp05327 <576951401@qq.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
In Github:
https://github.com/yp05327/test/blob/main/test.drawio
Updated:
UI changed