Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve commit record's ui in comment list #26619

Merged
merged 13 commits into from
Mar 14, 2024
Merged

Improve commit record's ui in comment list #26619

merged 13 commits into from
Mar 14, 2024

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Aug 21, 2023 •
edited

Before:
image
image

After:
image
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 21, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 21, 2023
@yp05327 yp05327 added the topic/ui Change the appearance of the Gitea UI label Aug 21, 2023
@yp05327 yp05327 changed the title Improve repo comment list details Improve dependencies change record in issue comment list Aug 21, 2023
@lunny lunny added this to the 1.21.0 milestone Aug 21, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 21, 2023
wxiaoguang
wxiaoguang reviewed Aug 21, 2023
View reviewed changes
web_src/css/repo.css Outdated Show resolved Hide resolved
@yp05327 yp05327 changed the title Improve dependencies change record in issue comment list Improve commit record's ui in comment list Aug 22, 2023
silverwind
silverwind reviewed Aug 22, 2023
View reviewed changes
web_src/css/repo.css Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 23, 2023
@puni9869
Copy link
Member

Sorry, what exactly changed in the UI screenshots. Having hard time to find the difference.

@eeyrjmr
Copy link
Contributor

eeyrjmr commented Aug 25, 2023

@puni9869 the text is now vertically aligned. you can (just) see it in the BEFORE/AFTER

@lunny lunny modified the milestones: 1.21.0, 1.22.0 Sep 21, 2023
@yp05327 yp05327 marked this pull request as draft November 6, 2023 01:17
@lunny lunny modified the milestones: 1.22.0, 1.23.0 Mar 4, 2024
@silverwind
Copy link
Member

Fix merge conflict?

@silverwind
Copy link
Member

Did not test it so far, but I guess I will.

@silverwind silverwind self-requested a review March 13, 2024 01:10
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Mar 13, 2024
@wxiaoguang
Copy link
Contributor

#26619 (comment) Have no idea about this comment, so I changed to draft. If it is ok (another approve), I will reopen it.

Why "no idea"? If you think it is a must, could you explain why? If it is not a must, could it just be removed?

@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Mar 13, 2024
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2024
@yp05327 yp05327 marked this pull request as ready for review March 13, 2024 08:10
wxiaoguang
wxiaoguang reviewed Mar 13, 2024
View reviewed changes
web_src/css/repo.css Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2024
@silverwind
Copy link
Member

Pushed a fix that uses flex-text-block and remove a unnecessary margin class:

image

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 14, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 14, 2024
@silverwind silverwind enabled auto-merge (squash) March 14, 2024 18:34
@silverwind silverwind merged commit ce085b2 into go-gitea:main Mar 14, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 14, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 15, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
9859580 
* giteaofficial/main:
  Update JS dependences (go-gitea#29797)
  Unify search boxes (go-gitea#29530)
  Fix document error about 'make trans-copy' (go-gitea#29710)
  Remove jQuery AJAX from the diff functions (go-gitea#29743)
  Fix Safari spinner rendering (go-gitea#29801)
  Remove jQuery AJAX from the `repo-issue.js` file (go-gitea#29776)
  Improve commit record's ui in comment list (go-gitea#26619)
  enable tailwind nesting (go-gitea#29746)
@6543 6543 modified the milestones: 1.23.0, 1.22.0 Mar 16, 2024
@yp05327 yp05327 deleted the improve-repo-comment-list-detail branch March 19, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@yp05327 @puni9869 @eeyrjmr @silverwind @lunny @wxiaoguang @delvh @GiteaBot @6543