Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix panic on gogs webhook creation #2675

Merged
merged 3 commits into from
Oct 8, 2017
Merged

fix panic on gogs webhook creation #2675

merged 3 commits into from
Oct 8, 2017

Conversation

daviian
Copy link
Member

@daviian daviian commented Oct 7, 2017 •
edited
Loading

As title.

Targets #2671
Needs backport to 1.2

@daviian
fix panic on gogs webhook creation
8e54639 
Signed-off-by: David Schneiderbauer <dschneiderbauer@gmail.com>
@lafriks
Copy link
Member

lafriks commented Oct 7, 2017 •
edited
Loading

@daviian I think it should also be fixed on line 423 func GogsHooksEditPost

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 7, 2017
@lafriks lafriks added this to the 1.3.0 milestone Oct 7, 2017
@codecov-io
Copy link

codecov-io commented Oct 7, 2017 •
edited
Loading

Codecov Report

Merging #2675 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2675   +/-   ##
=======================================
  Coverage   27.13%   27.13%           
=======================================
  Files          86       86           
  Lines       17062    17062           
=======================================
  Hits         4629     4629           
  Misses      11755    11755           
  Partials      678      678

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebac051...71f76b2. Read the comment docs.

@daviian
fix panic in gogs webhook edit
48fbf31 
Signed-off-by: David Schneiderbauer <dschneiderbauer@gmail.com>
@daviian
Copy link
Member Author

daviian commented Oct 7, 2017

@lafriks Done

@lafriks
Copy link
Member

lafriks commented Oct 8, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 8, 2017
@lunny
Copy link
Member

lunny commented Oct 8, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 8, 2017
@lunny lunny merged commit 0cef8ce into go-gitea:master Oct 8, 2017
@lunny lunny mentioned this pull request Oct 8, 2017
Closed
5 tasks
@lunny
Copy link
Member

lunny commented Oct 8, 2017

@daviian please send a backport PR to v1.2

daviian added a commit to daviian/gitea that referenced this pull request Oct 8, 2017
@daviian
fix panic on gogs webhook creation (go-gitea#2675)
57bd4df 
* fix panic on gogs webhook creation

Signed-off-by: David Schneiderbauer <dschneiderbauer@gmail.com>

* fix panic in gogs webhook edit

Signed-off-by: David Schneiderbauer <dschneiderbauer@gmail.com>
@daviian daviian mentioned this pull request Oct 8, 2017
Merged
@daviian daviian deleted the bugfix/gogs-create-webhook branch October 8, 2017 12:03
lunny pushed a commit that referenced this pull request Oct 9, 2017
@daviian @lunny
fix panic on gogs webhook creation (#2675) (#2676)
d1cec5e 
* fix panic on gogs webhook creation

Signed-off-by: David Schneiderbauer <dschneiderbauer@gmail.com>

* fix panic in gogs webhook edit

Signed-off-by: David Schneiderbauer <dschneiderbauer@gmail.com>
@lafriks lafriks added the backport/done All backports for this PR have been created label Oct 14, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@daviian @lafriks @codecov-io @lunny @tboerger