-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add oauth sign-in to registration page #26951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If users navigate first to the registration, they won't necessarily know what external auth sources are available. Most web apps I've seen have external auth sources available on the registration page.
Imo, this is only loosely related to the team invite PR.
Resolve
But I think it's better to move the code into a shared template. I guess the code was just copied&pasted. And I think #20242 should be fixed and merged, because it came early but nobody reviews (well, community driven, so it's also fine to close that one and take this one) |
So let's review that one. I think that PR includes all of this PR. |
Agreed, that PR looks nearly identical to mine 👍 |
Replaced by: #20242 |
This is a follow-on to #26550 and includes oauth signin on the registration page.
This is particularly important for invitations by email. A user without an account may be invited to join a team and will receive an activation link that first navigates to the registration page. However, this will be a confusing flow if they intend to use an external auth provider.