Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PR, milestone and label functionality if issue unit is disabled (#2710) #2714

Merged
merged 1 commit into from Oct 16, 2017
Merged

Fix PR, milestone and label functionality if issue unit is disabled (#2710) #2714

merged 1 commit into from Oct 16, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Oct 16, 2017

Backport of #2710 to release/1.2

@lafriks
Fix PR, milestone and label functionality if issue unit is disabled (g…
7bc6b34 
…o-gitea#2710)

* Fix PR, milestone and label functionality if issue unit is disabled or not assigned to user

* Fix multi-actions in PR page

* Change error message

* Fix comment update and delete functionality in PR
@lafriks lafriks added this to the 1.2.1 milestone Oct 16, 2017
@lafriks lafriks added the issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself label Oct 16, 2017
@bkcsoft
Copy link
Member

bkcsoft commented Oct 16, 2017

@lafriks no tests? :(

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 16, 2017
@lafriks
Copy link
Member Author

lafriks commented Oct 16, 2017

It would require way too many tests to add that I have time now. This functionality is partly already covered by current tests it just fixes specific case when issues are disabled for repository

@bkcsoft
Copy link
Member

bkcsoft commented Oct 16, 2017

Seems like 2 things are needed, 1) a repo with external issue-tracker set (doesn't have to work), 2) a PR that get's closed. Seems like it should be fairly simple to add that specific case (which should catch most of there errors)

@bkcsoft
Copy link
Member

bkcsoft commented Oct 16, 2017

by discord discussion, LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 16, 2017
@daviian
Copy link
Member

daviian commented Oct 16, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 16, 2017
@lafriks lafriks merged commit 13013e9 into go-gitea:release/v1.2 Oct 16, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lafriks @bkcsoft @daviian @tboerger