Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing wrong translation on sort type oldest/latest #2720

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

jonasfranz
Copy link
Member

This PR will fix #2717

It changes the translations of the "Oldest" and "Newest" sort option to the correct one.

@lafriks lafriks added type/bug topic/ui Change the appearance of the Gitea UI labels Oct 16, 2017
@lafriks lafriks added this to the 1.3.0 milestone Oct 16, 2017
@lafriks
Copy link
Member

lafriks commented Oct 16, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 16, 2017
@Morlinest
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 16, 2017
@codecov-io
Copy link

Codecov Report

Merging #2720 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2720   +/-   ##
=======================================
  Coverage   26.96%   26.96%           
=======================================
  Files          87       87           
  Lines       17297    17297           
=======================================
  Hits         4664     4664           
  Misses      11953    11953           
  Partials      680      680

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e865ce...dafafef. Read the comment docs.

@lafriks lafriks merged commit 33647aa into go-gitea:master Oct 16, 2017
@jonasfranz jonasfranz deleted the correcting-admin-link branch October 16, 2017 20:36
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/admin/users sorting options are incorrect
5 participants