Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download and pushing translations #2727

Merged
merged 3 commits into from
Nov 1, 2017
Merged

Conversation

jonasfranz
Copy link
Member

Replaces: #2592 because of rebase problems

This PR adds the following build steps:

download_translations: Downloads & exports all translations from crowdin and saves them into options/locale/
upload_translations: Uploads the updated locale_en-US.ini to Crowdin
The build steps are splitted because the files should only uploaded to crowdin if all test passes.

It also adds the ignore_branch option to fix the build process because gitea does not use branches at crowdin.

This is already tested here:

Upload & Export in custom folder: http://drone.jonasfranz.software/JonasFranzDEV/Crowdin-Demo/12
Used configuration: https://git.jonasfranz.software/JonasFranzDEV/Crowdin-Demo/src/master/.drone.yml
Related to #2585
Related to jonasfranz/drone-crowdin#2

@codecov-io
Copy link

codecov-io commented Oct 17, 2017

Codecov Report

Merging #2727 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2727   +/-   ##
=======================================
  Coverage   26.84%   26.84%           
=======================================
  Files          89       89           
  Lines       17608    17608           
=======================================
  Hits         4727     4727           
  Misses      12195    12195           
  Partials      686      686

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b6a962...8da8f26. Read the comment docs.

@jonasfranz jonasfranz force-pushed the patch-1 branch 2 times, most recently from c53a7d4 to ccd3577 Compare October 17, 2017 16:04
@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 17, 2017
download_translations:
image: jonasfranz/crowdin
pull: true
secrets: [ crowdin_key ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be added to drone server right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this is already added during the upload process

.drone.yml Outdated
git_push:
image: appleboy/drone-git-push
pull: true
secrets: [ git_push_ssh_key ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you should add the gut_push_ssh_key like described in the plug-in documentation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the git_push_ssh_key in drone secret.

@lafriks lafriks added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Oct 18, 2017
@lafriks lafriks added this to the 1.3.0 milestone Oct 18, 2017
.drone.yml Outdated
commit_message: "[skip ci] Updated translations via Crowdin"
when:
event: [ push ]
branch: [ master ]
pre-build:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an empty line between every pipeline steps.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@appleboy
Copy link
Member

appleboy commented Nov 1, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 1, 2017
@lunny
Copy link
Member

lunny commented Nov 1, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 1, 2017
@lunny lunny merged commit e9595a9 into go-gitea:master Nov 1, 2017
@jonasfranz
Copy link
Member Author

The CI build (https://drone.gitea.io/go-gitea/gitea/1582/6) fails due to an issue with the git push plug-in. Do somebody know why?
CC @appleboy

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants