Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove max-width and add hide text overflow #27359

Merged
merged 5 commits into from Oct 9, 2023
Merged

Remove max-width and add hide text overflow #27359

merged 5 commits into from Oct 9, 2023

Conversation

kdumontnu
Copy link
Contributor

Closes #27358

I'm happy for someone else to take this over if there is a more desirable solution, but this seemed like the simplest fix to me.

Before:
image

After:
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 29, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 29, 2023
@github-actions github-actions bot added the topic/ui Change the appearance of the Gitea UI label Sep 29, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 30, 2023
puni9869
puni9869 reviewed Sep 30, 2023
View reviewed changes
templates/repo/issue/view_content/sidebar.tmpl Outdated
@@ -468,7 +468,7 @@
{{.Repository.OwnerName}}/{{.Repository.Name}}
</div>
</div>
<div class="item-right gt-df gt-ac">
<div class="item-right gt-df gt-ac gt-m-2">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="item-right gt-df gt-ac gt-m-2">
<div class="item-right gt-df gt-ac gt-m-2">

puni9869
puni9869 reviewed Sep 30, 2023
View reviewed changes
templates/repo/issue/view_content/sidebar.tmpl Outdated
@@ -491,7 +491,7 @@
{{.Repository.OwnerName}}/{{.Repository.Name}}
</div>
</div>
<div class="item-right gt-df gt-ac">
<div class="item-right gt-df gt-ac gt-m-2">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="item-right gt-df gt-ac gt-m-2">
<div class="item-right gt-df gt-ac gt-m-2">

@puni9869
Copy link
Member

could you apply the elipsis ... for description.
image

I have one more suggestion:
Add tooltip, this will retain the full name on hover.

@silverwind
Copy link
Member

silverwind commented Sep 30, 2023 •
edited

Yes, ... ellipsis should be visible. The fact that it's not indicates there is something wrong with the styling.

@puni9869
Copy link
Member

Yes, ... ellipsis should be visible. The fact that it's not indicated there is something wrong with the styling.

style was not applied

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 9, 2023
@kdumontnu
Copy link
Contributor Author

@puni9869 @silverwind should be all set now.

Added tooltips. They are a bit off in terms of styling, which bugs me, but is out of the scope of this PR.
ellipsis

@kdumontnu kdumontnu added the backport/v1.21 This PR should be backported to Gitea 1.21 label Oct 9, 2023
techknowlogick
techknowlogick approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 thanks!

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 9, 2023
@techknowlogick techknowlogick merged commit ac4ae35 into go-gitea:main Oct 9, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Oct 9, 2023
@GiteaBot GiteaBot mentioned this pull request Oct 9, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 9, 2023
@kdumontnu @GiteaBot
Remove max-width and add hide text overflow (go-gitea#27359)
0728b6e 
Closes go-gitea#27358
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Oct 9, 2023
techknowlogick pushed a commit that referenced this pull request Oct 10, 2023
@GiteaBot @kdumontnu
Remove max-width and add hide text overflow (#27359) (#27550)
71f091e 
Backport #27359 by @kdumontnu

Closes #27358

Co-authored-by: Kyle D <kdumontnu@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 10, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
087dfb1 
* giteaofficial/main:
  Respect SSH.KeygenPath option when calculating ssh key fingerprints (go-gitea#27536)
  Remove max-width and add hide text overflow (go-gitea#27359)
  Fix `environment-to-ini` inherited key bug (go-gitea#27543)
  Improve docs about register/run as a service (go-gitea#27461)
  api: GetPullRequestCommits: return file list (go-gitea#27483)
  switch to using official AWS step in release nightly (go-gitea#27532)
  Improve file history UI and fix URL escaping bug (go-gitea#27531)
  Improve dropdown's behavior when there is a search input in menu (go-gitea#27526)
  Simplify `contrib/backport` (go-gitea#27520)
  Add docs section for sub-paths with the container registry (go-gitea#27505)
  Document our new labeling strategy (go-gitea#27523)
  [skip ci] Updated translations via Crowdin
  Restore warning commit status (go-gitea#27504)
  Update labeler to match new labeling system (go-gitea#27525)
  Apply to become a maintainer (go-gitea#27522)
  Remove unnecessary desc for openssh key cron task (go-gitea#27515)
  Tweak labeler config (go-gitea#27502)
  Add hover background to wiki list page (go-gitea#27507)
  [FIX] missing ctx in new_form (go-gitea#27514)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@puni9869 puni9869 puni9869 left review comments

@techknowlogick techknowlogick techknowlogick approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Issue Dependencies Overflow
6 participants
@kdumontnu @puni9869 @silverwind @techknowlogick @delvh @GiteaBot