Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test more templates for if they contain an error #27367

Merged
merged 7 commits into from
Oct 2, 2023
Merged

Test more templates for if they contain an error #27367

merged 7 commits into from
Oct 2, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 30, 2023

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 30, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 30, 2023
@lunny lunny added type/testing and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 30, 2023
@delvh delvh changed the title Add more links test to avoid borken templates Test more templates for if they contain an error Sep 30, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 30, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 30, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 30, 2023
@puni9869
Copy link
Member

Test cases are failing, new links are giving 404 in unit tests

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 2, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 2, 2023
@lunny lunny enabled auto-merge (squash) October 2, 2023 07:06
@GiteaBot
Copy link
Contributor

GiteaBot commented Oct 2, 2023

@lunny please fix the merge conflicts. 🍵

@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 2, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 2, 2023
@lunny lunny mentioned this pull request Oct 2, 2023
Open
@lunny lunny merged commit 439a0cc into go-gitea:main Oct 2, 2023
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Oct 2, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 2, 2023
@lunny lunny deleted the lunny/more_links_test branch October 2, 2023 08:23
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CaiCandong CaiCandong CaiCandong approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/testing
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lunny @puni9869 @GiteaBot @CaiCandong @delvh