Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix yet another ctx template bug (#27417) #27426

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Fix yet another ctx template bug (#27417) #27426

merged 3 commits into from
Oct 4, 2023

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Oct 4, 2023

Backport #27417 by @delvh

Fixes #27416

@GiteaBot GiteaBot added type/bug topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Oct 4, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Oct 4, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 4, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 4, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 4, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 4, 2023
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 4, 2023
@silverwind silverwind enabled auto-merge (squash) October 4, 2023 06:57
@silverwind silverwind merged commit 99e2071 into go-gitea:release/v1.21 Oct 4, 2023
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 4, 2023
@delvh delvh mentioned this pull request Oct 6, 2023
Closed
delvh added a commit to delvh/gitea that referenced this pull request Oct 6, 2023
@delvh
Revert "Fix yet another ctx template bug (go-gitea#27417) (go-gitea…
9e194f6 
…#27426)"

This reverts commit 99e2071.
lunny pushed a commit that referenced this pull request Oct 6, 2023
@delvh
Revert #27426 (#27474)
9207331 
Apparently, we didn't backport one of the refactoring PRs which caused
the fixup we backported to fail.

Fixes: #27473
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

@silverwind silverwind Awaiting requested review from silverwind

@techknowlogick techknowlogick Awaiting requested review from techknowlogick

Assignees

@delvh delvh

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GiteaBot @lunny @delvh @silverwind