Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove manual of unsupported option #2757

Merged
merged 1 commit into from
Oct 21, 2017
Merged

Remove manual of unsupported option #2757

merged 1 commit into from
Oct 21, 2017

Conversation

Morlinest
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 21, 2017 •
edited
Loading

Codecov Report

Merging #2757 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2757   +/-   ##
======================================
  Coverage    26.9%   26.9%           
======================================
  Files          88      88           
  Lines       17289   17289           
======================================
  Hits         4652    4652           
  Misses      11958   11958           
  Partials      679     679

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e9e48b...838ec1d. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 21, 2017
@andreynering
Copy link
Contributor

nssm doesn't work anymore, because Gitea now uses minwinsvc, which is not compatible with it.

We should actually delete this folder.

@Morlinest Morlinest force-pushed the fix/install-as-service-manual branch from 48dbb37 to 838ec1d Compare October 21, 2017 21:19
@Morlinest Morlinest changed the title Use "gitea" in install as service windows manual Remove manual of unsupported option Oct 21, 2017
@Morlinest
Copy link
Member Author

@andreynering Changed PR to remove windows folder with old manual.

@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 21, 2017
@andreynering
Copy link
Contributor

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 21, 2017
@andreynering andreynering merged commit a257f88 into go-gitea:master Oct 21, 2017
@Morlinest Morlinest deleted the fix/install-as-service-manual branch October 21, 2017 23:18
@andreynering
Copy link
Contributor

@Morlinest Merged, thanks.

@lunny lunny added this to the 1.3.0 milestone Oct 22, 2017
@lunny lunny added the type/enhancement An improvement of existing functionality label Oct 22, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Morlinest @codecov-io @andreynering @ethantkoenig @lunny @tboerger