Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data-race bug when accessing task.LastRun #27584

Merged
merged 3 commits into from Oct 11, 2023
Merged

Fix data-race bug when accessing task.LastRun #27584

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bab437
fix
wxiaoguang Oct 11, 2023
3d612d0
Merge branch 'main' into fix-task-datarace
wxiaoguang Oct 11, 2023
a587a08
Merge branch 'main' into fix-task-datarace
GiteaBot Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions services/cron/cron.go
View file
Open in desktop
Expand Up @@ -107,12 +107,11 @@ func ListTasks() TaskTable {
prev = e.PreviousRun()
}

task.lock.Lock()
// If the manual run is after the cron run, use that instead.
if prev.Before(task.LastRun) {
prev = task.LastRun
}

task.lock.Lock()
tTable = append(tTable, &TaskTableRow{
Name: task.Name,
Spec: spec,
Expand Down