packages: Calculate package size quota using package creator ID instead of owner ID #28007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
github-actions
bot
added
the
modifies/api
ghost
force-pushed
the
fix-package-quota-org-limit
branch
from
d906744
to
cc18078
Compare
github-actions
bot
removed
the
modifies/api
silverwind
approved these changes
Nov 13, 2023
GiteaBot
added
lgtm/need 1
6543
added
type/enhancement
6543
approved these changes
Nov 13, 2023
GiteaBot
added
lgtm/done
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Nov 13, 2023
…ad of owner ID (go-gitea#28007) Changed behavior to calculate package quota limit using package `creator ID` instead of `owner ID`. Currently, users are allowed to create an unlimited number of organizations, each of which has its own package limit quota, resulting in the ability for users to have unlimited package space in different organization scopes. This fix will calculate package quota based on `package version creator ID` instead of `package version owner ID` (which might be organization), so that users are not allowed to take more space than configured package settings. Also, there is a side case in which users can publish packages to a specific package version, initially published by different user, taking that user package size quota. Version in fix should be better because the total amount of space is limited to the quota for users sharing the same organization scope.
|
I don't think this is right. Every user/org should have their package size quota. What we should do is to limit org's package size but not creators'. |
|
hmm we dont have a org setting to limit right now ... so the fix is good. but I agree that a long term solution should be to have orgs own limits |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 14, 2023
* upstream/main: fixed duplicate attachments on dump on windows (go-gitea#28019) [skip ci] Updated translations via Crowdin packages: Calculate package size quota using package creator ID instead of owner ID (go-gitea#28007) Dont leak private users via extensions (go-gitea#28023) Improve profile for Organizations (go-gitea#27982) Enable system users search via the API (go-gitea#28013) Enable system users for comment.LoadPoster (go-gitea#28014) Change default size of issue/pr attachments and repo file (go-gitea#27946) Fix missing mail reply address (go-gitea#27997)
|
This should be reverted. If you use CI with bot users the quota limit is never reached for a user. A solution could be to have different quotes for owner and creator. Now the description of the ini setting is wrong too. |
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Nov 14, 2023
…ID instead of owner ID (go-gitea#28007)" This reverts commit 60522fc.
6543
pushed a commit
that referenced
this pull request
Nov 14, 2023
6543
added
skip-changelog
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 15, 2023
* upstream/main: Revert "packages: Calculate package size quota using package creator ID instead of owner ID (go-gitea#28007)" (go-gitea#28049) Restricted users only see repos in orgs which their team was assigned to (go-gitea#28025) Fix release link in changelog for v1.21.0 Add v1.21.0 changelog (go-gitea#28005) Fix viewing wiki commit on empty repo (go-gitea#28040) Add word break to the repo list in admin settings page (go-gitea#28034)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
…ad of owner ID (go-gitea#28007) Changed behavior to calculate package quota limit using package `creator ID` instead of `owner ID`. Currently, users are allowed to create an unlimited number of organizations, each of which has its own package limit quota, resulting in the ability for users to have unlimited package space in different organization scopes. This fix will calculate package quota based on `package version creator ID` instead of `package version owner ID` (which might be organization), so that users are not allowed to take more space than configured package settings. Also, there is a side case in which users can publish packages to a specific package version, initially published by different user, taking that user package size quota. Version in fix should be better because the total amount of space is limited to the quota for users sharing the same organization scope.
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
…ID instead of owner ID (go-gitea#28007)" (go-gitea#28049) This reverts commit go-gitea#28007 60522fc.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed behavior to calculate package quota limit using package
creator IDinstead ofowner ID.Currently, users are allowed to create an unlimited number of organizations, each of which has its own package limit quota, resulting in the ability for users to have unlimited package space in different organization scopes. This fix will calculate package quota based on
package version creator IDinstead ofpackage version owner ID(which might be organization), so that users are not allowed to take more space than configured package settings.Also, there is a side case in which users can publish packages to a specific package version, initially published by different user, taking that user package size quota. Version in fix should be better because the total amount of space is limited to the quota for users sharing the same organization scope.