Use api.TrackedTime in API #2807
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2807 +/- ##
==========================================
- Coverage 26.85% 26.84% -0.02%
==========================================
Files 89 89
Lines 17600 17608 +8
==========================================
Hits 4727 4727
- Misses 12187 12195 +8
Partials 686 686
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
routers/api/v1/convert/convert.go
Outdated
| @@ -190,3 +190,14 @@ func ToTeam(team *models.Team) *api.Team { | |||
| Permission: team.Authorize.String(), | |||
| } | |||
| } | |||
|
|
|||
| // ToTrackedTime convert models.TrackedTime to api.TrackedTime | |||
| func ToTrackedTime(trackedTime *models.TrackedTime) *api.TrackedTime { | |||
There was a problem hiding this comment.
I think this better would be as model method APIFormat() like this:
Line 268 in aa962de
There was a problem hiding this comment.
@lafriks Done. Out of curiosity, why do you prefer a TrackedTime.APIFormat() method to a convert.ToTrackedTeam function?
There was a problem hiding this comment.
@ethantkoenig it's just more straightforward and when just converting model to api type (1:1) I think there is no need for special function
| @@ -10,6 +10,14 @@ import ( | |||
| api "code.gitea.io/sdk/gitea" | |||
| ) | |||
|
|
|||
| func convertTrackedTimes(trackedTimes []*models.TrackedTime) []*api.TrackedTime { | |||
There was a problem hiding this comment.
convertTrackedTimes should also probably more specific for example convertTrackedTimesToAPIFormat otherwise it's hard to understand just from name what it does acutally
There was a problem hiding this comment.
Renamed to trackedTimesToAPIFormat
|
LGTM |
tboerger
added
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
|
Do you regenerated swagger? |
lunny
added
the
type/refactoring
|
@JonasFranzDEV I think this is only a refactor. It's no need. |
Use
api.TrackedTimeinstead ofmodels.TrackedTimein responses from time-tracking API endpoints.cc @JonasFranzDEV