Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order of comments #2835

Merged
merged 1 commit into from
Nov 3, 2017
Merged

Fix order of comments #2835

merged 1 commit into from
Nov 3, 2017

Conversation

Morlinest
Copy link
Member

Simple change. If comments have same created_unix time, use id for ordering.

Before:
image

After:
chrome_2017-11-03_02-49-43

@codecov-io
Copy link

Codecov Report

Merging #2835 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2835      +/-   ##
==========================================
+ Coverage   26.84%   26.84%   +<.01%     
==========================================
  Files          89       89              
  Lines       17608    17609       +1     
==========================================
+ Hits         4727     4728       +1     
  Misses      12195    12195              
  Partials      686      686
Impacted Files Coverage Δ
models/issue_comment.go 30.6% <100%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e08f23...db83732. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 3, 2017
@lunny lunny added the type/bug label Nov 3, 2017
@lunny lunny added this to the 1.3.0 milestone Nov 3, 2017
@lunny
Copy link
Member

lunny commented Nov 3, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 3, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 3, 2017
@lunny lunny merged commit 95637e0 into go-gitea:master Nov 3, 2017
@lunny
Copy link
Member

lunny commented Nov 3, 2017

@Morlinest please send a back port PR to v1.2

@ethantkoenig ethantkoenig mentioned this pull request Nov 3, 2017
Merged
Morlinest added a commit to Morlinest/gitea that referenced this pull request Nov 3, 2017
@Morlinest
Fix order of comments (go-gitea#2835)
0e936d8
@Morlinest Morlinest mentioned this pull request Nov 3, 2017
Merged
@Morlinest Morlinest deleted the fix/issue-event-ordering branch November 3, 2017 11:13
@lafriks lafriks added the backport/done All backports for this PR have been created label Nov 3, 2017
lafriks pushed a commit that referenced this pull request Nov 3, 2017
@Morlinest @lafriks
Fix order of comments (#2835) (#2839)
de7a76a
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Morlinest @codecov-io @lunny @ethantkoenig @tboerger @lafriks