Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show unnecessary citation JS error on UI #28433

Merged
merged 2 commits into from Dec 12, 2023
Merged

Don't show unnecessary citation JS error on UI #28433

merged 2 commits into from Dec 12, 2023

Conversation

wxiaoguang
Copy link
Contributor

Fix #28226

@wxiaoguang wxiaoguang added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 labels Dec 12, 2023
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Dec 12, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 12, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 12, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 12, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 12, 2023
@lunny lunny enabled auto-merge (squash) December 12, 2023 08:51
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 12, 2023
@lunny lunny merged commit 0a794b2 into go-gitea:main Dec 12, 2023
25 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 12, 2023
@wxiaoguang @GiteaBot
Don't show unnecessary citation JS error on UI (go-gitea#28433)
3c5bfd8 
Fix go-gitea#28226
@GiteaBot GiteaBot mentioned this pull request Dec 12, 2023
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Dec 12, 2023
@wxiaoguang wxiaoguang deleted the fix-citation-js branch December 12, 2023 11:32
wxiaoguang added a commit that referenced this pull request Dec 12, 2023
@GiteaBot @wxiaoguang
Don't show unnecessary citation JS error on UI (#28433) (#28437)
5e2bae7 
Backport #28433 by wxiaoguang

Fix #28226

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 13, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
b4a4443 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix possible nil pointer access (go-gitea#28428)
  Don't show unnecessary citation JS error on UI (go-gitea#28433)
  Do some missing checks (go-gitea#28423)
  Deprecate query string auth tokens (go-gitea#28390)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@wxiaoguang @fuxiaohei
Don't show unnecessary citation JS error on UI (go-gitea#28433)
bb4b65f 
Fix go-gitea#28226
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@wxiaoguang @silverwind
Don't show unnecessary citation JS error on UI (go-gitea#28433)
3de91ed 
Fix go-gitea#28226
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

JavaScript WARNING/ERROR: JavaScript promise rejection
5 participants
@wxiaoguang @lunny @silverwind @delvh @GiteaBot