Update swagger documentation #2899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add docs for missing endpoints Add documentation for request parameters Make parameter naming consistent Fix response documentation
ethantkoenig
force-pushed
the
swagger
branch
from
24c1a0e
to
d4e9781
Compare
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #2899 +/- ##
==========================================
+ Coverage 27% 27.05% +0.04%
==========================================
Files 89 89
Lines 17644 17650 +6
==========================================
+ Hits 4765 4775 +10
+ Misses 12193 12189 -4
Partials 686 686
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 1
sapk
reviewed
Nov 13, 2017
routers/api/v1/api.go
Outdated
| @@ -1,15 +1,7 @@ | |||
| // Copyright 2015 The Gogs Authors. All rights reserved. | |||
There was a problem hiding this comment.
Why you remove copyrigths ? We could add gitea ones ?
sapk
reviewed
Nov 13, 2017
routers/api/v1/api.go
Outdated
| // license that can be found in the LICENSE file. | ||
|
|
||
| // Package v1 Gitea API. | ||
| // | ||
| // This provide API interface to communicate with this Gitea instance. |
|
Two little comments that should be fixed. For the rest LGTM. Thanks for doing it, it takes time and few good catch like https://github.com/go-gitea/gitea/pull/2899/files#diff-2620fdbeeb83ce43692534e6c2c39452R315. |
tboerger
added
lgtm/done
|
@sapk Fixed. The "Terms of Service" link doesn't work, so that is still removed, everything else is restored. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2635. This PR fixes the following:
This PR has no functional change.