Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes for Project-Board-Columns #29045

Open
wants to merge 47 commits into
base: main
Choose a base branch
from

Conversation

zokkis
Copy link
Contributor

@zokkis zokkis commented Feb 4, 2024

Functionality

  • view, create, edit, move, delete
  • create issue from note - title and content is prefilled
  • support organizations/user projects
  • support for milestone, labels
  • pin notes like issues

Closes #12513
Closes #29029
Closes #29031
Fixes a bug that the wrong cursor was used on column-title

image


This is my first time working with GO, so please be nice and I will try anything to help with this feature

@GiteaBot
Copy link
Contributor

GiteaBot commented Feb 4, 2024

@gitZokki I noticed you've updated the locales for non-English languages. These will be overwritten during the sync from our translation tool Crowdin. If you'd like to contribute your translations, please visit https://crowdin.com/project/gitea. Please revert the changes done on these files. 🍵

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 4, 2024
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 4, 2024
@zokkis
Copy link
Contributor Author

zokkis commented Feb 4, 2024

After a few more hours I have more questions

  • why are the ids in int64 and not uint64?
  • how should the permission be handled, because currently everybody who has write-permissions to the repo can add and edit notes and pin/unpin them, but only admin can pin issues
  • should the note be deleted when the user creates a issue from a note?

In the feature-request for the BoardNotes there are some things I think are not important to add

  • 'Ability to assign a person' -> no, because you can create a issue and assign the person to the issue and notes should be simple
  • 'priority' -> with the order should the prio be set, there is also the option to pin and add labels
  • '"private" options' -> I don't think its usefull

@zokkis zokkis changed the title WIP: Feature: Notes for Project-Board-Columns Feature: Notes for Project-Board-Columns Feb 4, 2024
@zokkis zokkis requested a review from KN4CK3R February 9, 2024 03:32
@KN4CK3R KN4CK3R added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Feb 16, 2024
@KN4CK3R KN4CK3R changed the title Feature: Notes for Project-Board-Columns Notes for Project-Board-Columns Feb 16, 2024
@6543 6543 added this to the 1.22.0 milestone Feb 25, 2024
@lunny lunny modified the milestones: 1.22.0, 1.23.0 Mar 4, 2024
@silverwind
Copy link
Member

Seems I've completely missed this, sorry. I think I can give the frontend parts a proper review but I do see multiple areas that will need quite a bit of work. One question:

image

Why do note cards render these "duplicates" above?

@lunny
Copy link
Member

lunny commented Apr 19, 2024

Maybe we can merge #30170 first.

@silverwind
Copy link
Member

Maybe we can merge #30170 first.

Whichever is ready first will be first and the other will suffer merge conflicts 😆.

@lunny lunny mentioned this pull request May 7, 2024
13 tasks
@yp05327
Copy link
Contributor

yp05327 commented May 9, 2024

Does this PR contains the fix in #26561?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/migrations modifies/translation size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. topic/projects type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
7 participants