Customizable "Open with" applications for repository clone

[wxiaoguang]

I think this approach is simple and flexible enough. And it is a complete solution.

Replace #22378
Close #21121
Close #22149

Default

Customized

[wxiaoguang]

At the moment, it doesn't support user-level customization, because the "user setting" package is not that mature as the system setting package. It should be easy to add user-level setting in the future, just override the system setting.

[lunny]

Can we add a reset button?

[wxiaoguang]

Can we also add gitpod as default?

ffbe671 , I am not sure whether it works.

Can we add a reset button?

Just clear the textarea, then this setting is reset.

[lunny]

Can we also add gitpod as default?

ffbe671 , I am not sure whether it works.
blocked by gitpod-io/gitpod#8131

Can we add a reset button?

Just clear the textarea, then this setting is reset.

[wxiaoguang]

Can we also add gitpod as default?

ffbe671 , I am not sure whether it works.

blocked by gitpod-io/gitpod#8131

So feel free to remove it.

[jolheiser]

Can this be sourced from the config as well? I don't recall if we have a mechanism for that.

[wxiaoguang]

Can this be sourced from the config as well? I don't recall if we have a mechanism for that.

If anyone really needs "sourcing from the config", I could propose a following PR. The "system setting" package has the ability to do so. But I do not think it's worth to do so at the moment. I guess we don't want to maintain too many config systems or config documents.

[lunny]

Can this be sourced from the config as well? I don't recall if we have a mechanism for that.

I would like to move most configurations from app.ini to database/UI but not the opposite.
For app.ini configuration, it needs to restart once the configuration changed.

[jolheiser]

Then perhaps an API/CLI to set these things. My concern is only being able to set/change these from the web UI. Manually fiddling with the database seems like a no-go for deployment purposes.

[wxiaoguang]

Then perhaps an API/CLI to set these things. My concern is only being able to set/change these from the web UI. Manually fiddling with the database seems like a no-go for deployment purposes.

Sure, I fully understand this point. So if there is a real requirement in the future, I will propose related solutions.

[lunny]

Then perhaps an API/CLI to set these things. My concern is only being able to set/change these from the web UI. Manually fiddling with the database seems like a no-go for deployment purposes.

Maybe a generic Configuration API is better.

[delvh]

Could you please add a docs page showing what common editors expect?
That way, users know what they are supposed to enter without much doubt.
(It does not need to be complete, that's what we have the community for. If they want another editor, they are free to open a PR.)

[wxiaoguang]

Could you please add a docs page showing what common editors expect?

Sorry I didn't quite catch your point. Could you elaborate "what kind of doc page / where to be put" and what is "what common editors expect" ?

---

If you mean that "show users the example links for some editors", you could just click here, then you will see all builtin editors, they could be used as example.

[delvh]

Is there perhaps any way to set a custom icon, i.e. as a file path?
Once we have this option, this feature is truly complete.

[wxiaoguang]

I have left a TODO in code:

iconHTML = svg.RenderHTML("gitea-git", 16, "gt-mr-3") // TODO: it could support user's customized icon in the future

To support "custom icon", it needs far more changes: it needs an extra field, and needs a new UI editor for the config items (at least, a YAML or JSON editor). It still needs the end user to upload the icon to "somewhere", I guess most users would be quite lazy to do so .....

So at the moment, the default "git" icons looks not bad.

[silverwind]

SVG icons could be entered as text in that box, e.g. name=url,icon=<svg/>. That said, I kind of dislike that the current syntax is not pure key=value pairs.

[wxiaoguang]

Yup, that's why I think "and needs a new UI editor for the config items (at least, a YAML or JSON editor)".

Let's collect more user feedbacks, to see how to move on.

[silverwind]

I guess we better already change the syntax to yaml/json now.

[wxiaoguang]

That's quite easy because it is stored as JSON in database. So, it could be rendered as JSON or YAML in the editor easily. It won't block anything.