Improve Documentation for Restoration from backup #29321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by default, repositories is a subfolder of data/ `%(APP_DATA_PATH)s/gitea-repositories`
after update, bare git repositories might throw ``` [E] RepoAssignment Invalid repo /var/lib/gitea/data/gitea-repositories/tester/testrepo.git: exit status 128 - fatal: not a git repository (or any of the parent directories): .git 2024/02/22 11:50:44 ...eb/routing/logger.go:102:func1() [I] router: completed GET /tester/testrepo for, 500 Internal Server Error in 5.4ms @ context/repo.go:425(context.RepoAssignment) ```
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
wxiaoguang
approved these changes
Feb 24, 2024
GiteaBot
added
lgtm/need 1
silverwind
reviewed
Feb 24, 2024
| @@ -92,7 +92,7 @@ cd gitea-dump-1610949662 | |||
| mv app.ini /etc/gitea/conf/app.ini | |||
| mv data/* /var/lib/gitea/data/ | |||
| mv log/* /var/lib/gitea/log/ | |||
| mv repos/* /var/lib/gitea/gitea-repositories/ | |||
| mv repos/* /var/lib/gitea/data/gitea-repositories/ | |||
There was a problem hiding this comment.
We seem to be inconsistent with this path throughout the docs, would suggest cleaning up:
$ rg gitea-repositories docs
docs/content/help/faq.en-us.md:76: - Default `%(APP_DATA_PATH)/gitea-repositories`
docs/content/help/faq.zh-cn.md:77: - 默认值为`%(APP_DATA_PATH)/gitea-repositories`
docs/content/administration/config-cheat-sheet.zh-cn.md:78:- `ROOT`: **%(APP_DATA_PATH)s/gitea-repositories**: 存放git工程的根目录，建议填绝对路径。
docs/content/administration/backup-and-restore.zh-cn.md:34:2016/12/27 22:32:09 Dumping local repositories.../home/git/gitea-repositories
docs/content/administration/backup-and-restore.zh-cn.md:91:mv repos/* /var/lib/gitea/gitea-repositories/
docs/content/administration/backup-and-restore.zh-cn.md:125:mv repos/* /data/git/gitea-repositories/
docs/content/administration/backup-and-restore.zh-cn.md:149:mv repos/* /var/lib/gitea/git/gitea-repositories
docs/content/administration/config-cheat-sheet.en-us.md:78:- `ROOT`: **%(APP_DATA_PATH)s/gitea-repositories**: Root path for storing all repository data.
docs/content/administration/config-cheat-sheet.en-us.md:550:- `ONLY_ALLOW_PUSH_IF_GITEA_ENVIRONMENT_SET`: **true**: Set to `false` to allow local users to push to gitea-repositories without setting up the Gitea environment. This is not recommended and if you want local users to push to Gitea repositories you should set the environment appropriately.
docs/content/administration/backup-and-restore.en-us.md:36:2016/12/27 22:32:09 Dumping local repositories.../home/git/gitea-repositories
docs/content/administration/backup-and-restore.en-us.md:95:mv repos/* /var/lib/gitea/gitea-repositories/
docs/content/administration/backup-and-restore.en-us.md:129:mv repos/* /data/git/gitea-repositories/
docs/content/administration/backup-and-restore.en-us.md:153:mv repos/* /var/lib/gitea/git/gitea-repositories
There was a problem hiding this comment.
It's impossible to make them consistent.
- Some are by default systemd installation, eg: /var/lib/gitea/data/gitea-repositories/
- Some are caused by bugs: /var/lib/gitea/gitea-repositories/
- Some are for docker: /data/git/gitea-repositories/
- Some are for docker rootless: /var/lib/gitea/git/gitea-repositories
There was a problem hiding this comment.
Indeed, site admin should learn how to handle directories correctly .....
silverwind
approved these changes
Feb 25, 2024
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 26, 2024
* giteaofficial/main: (45 commits) Include resource state events in Gitlab downloads (go-gitea#29382) Add API to get PR by base/head (go-gitea#29242) [skip ci] Updated translations via Crowdin Improve Documentation for Restoration from backup (go-gitea#29321) Refactor "user/active" related logic (go-gitea#29390) Remove jQuery AJAX from the archive download links (go-gitea#29380) Add tailwindcss (go-gitea#29357) Add missing space (go-gitea#29393) Integrate alpine `noarch` packages into other architectures index (go-gitea#29137) enforce maxlength in frontend (go-gitea#29389) Remove incorrect and unnecessary Escape from templates (go-gitea#29394) Make actions animation rotate counterclockwisely (go-gitea#29378) Use `crypto/sha256` (go-gitea#29386) Add `io.Closer` guidelines (go-gitea#29387) Remove jQuery AJAX from the notice selection deletion button (go-gitea#29381) Refactor Safe modifier (go-gitea#29392) Add attachment support for code review comments (go-gitea#29220) Refactor modules/git global variables (go-gitea#29376) Remove jQuery from the code diff expansion buttons (go-gitea#29385) Remove jQuery AJAX from the markdown editor preview (go-gitea#29384) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment the default path for repos and suggest using doctor for when things are stuck