Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix htmx rendering the login page in frame on session logout #29405

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Fix htmx rendering the login page in frame on session logout #29405

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
338fe5d
Fix htmx rendering the login page in frame on session logout
yardenshoham Feb 25, 2024
8d772e7
Merge branch 'main' into issues/29391
yardenshoham Feb 26, 2024
d0ab0f0
Merge branch 'main' into issues/29391
GiteaBot Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions modules/context/base.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,14 @@ func (b *Base) Redirect(location string, status ...int) {
// So in this case, we should remove the session cookie from the response header
removeSessionCookieHeader(b.Resp)
}
// in case the request is made by htmx, have it redirect the browser instead of trying to follow the redirect inside htmx
if b.Req.Header.Get("HX-Request") == "true" {
b.Resp.Header().Set("HX-Redirect", location)
// we have to return a non-redirect status code so XMLHTTPRequest will not immediately follow the redirect
// so as to give htmx redirect logic a chance to run
b.Status(http.StatusNoContent)
return
}
http.Redirect(b.Resp, b.Req, location, code)
}

Expand Down
Loading