Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix template bug (#27581) #29446

Merged
merged 2 commits into from Feb 27, 2024
Merged

Fix template bug (#27581) #29446

merged 2 commits into from Feb 27, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 27, 2024

Fix #29152
Backport #27581

@lunny lunny added the type/bug label Feb 27, 2024
@lunny lunny added this to the 1.21.8 milestone Feb 27, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 27, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 27, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Feb 27, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 27, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 27, 2024
@lunny lunny enabled auto-merge (squash) February 27, 2024 10:37
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 27, 2024
@lunny lunny merged commit dc48eb0 into go-gitea:release/v1.21 Feb 27, 2024
27 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 27, 2024
@lunny lunny deleted the lunny/fix_template2 branch February 27, 2024 12:30
@lunny lunny mentioned this pull request Feb 27, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@lng2020 lng2020 lng2020 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.21.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lunny @delvh @lng2020 @GiteaBot