Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect subpath in links (#29535) #29541

Merged
merged 1 commit into from Mar 2, 2024

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Mar 2, 2024

Backport #29535 by wxiaoguang

  • $referenceUrl: it is constructed by "Issue.Link", which already has the "AppSubURL"
  • window.location.href: AppSubURL could be empty string, so it needs the trailing slash

* `$referenceUrl`: it is constructed by "Issue.Link", which already has
the "AppSubURL"
* `window.location.href`: AppSubURL could be empty string, so it needs
the trailing slash
@GiteaBot GiteaBot added this to the 1.21.8 milestone Mar 2, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 2, 2024
@GiteaBot GiteaBot requested review from delvh and lunny March 2, 2024 12:02
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 2, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 2, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) March 2, 2024 12:03
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 2, 2024
@wxiaoguang wxiaoguang merged commit 401cc39 into go-gitea:release/v1.21 Mar 2, 2024
27 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants