Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jQuery AJAX from the comment edit history #29703

Merged
merged 1 commit into from Mar 10, 2024
Merged

Remove jQuery AJAX from the comment edit history #29703

merged 1 commit into from Mar 10, 2024

Conversation

yardenshoham
Copy link
Member

  • Removed all jQuery AJAX calls and replaced with our fetch wrapper
  • Tested the comment edit history list, diff, and delete functionality and it works as before

Demo using fetch instead of jQuery AJAX

demo

@yardenshoham
Remove jQuery AJAX from the comment edit history
277826a 
- Removed all jQuery AJAX calls and replaced with our fetch wrapper
- Tested the comment edit history list, diff, and delete functionality and it works as before

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 10, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 10, 2024
@yardenshoham yardenshoham added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 10, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 10, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 10, 2024
@6543 6543 merged commit b5ed428 into go-gitea:main Mar 10, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 10, 2024
@yardenshoham yardenshoham deleted the repo-issue-content-jquery-ajax branch March 10, 2024 19:27
@6543 6543 modified the milestones: 1.23.0, 1.22.0 Mar 10, 2024
@6543
Copy link
Member

6543 commented Mar 10, 2024

rm jQuery is better to have in asap :)

zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 11, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
139f55a 
* giteaofficial/main:
  Use repo object format name instead of detecting from git repository (go-gitea#29702)
  Improve CSV rendering (go-gitea#29638)
  Remove jQuery AJAX from the comment edit history (go-gitea#29703)
  fix: rendering internal file links in org (go-gitea#29669)
  Fix broken webhooks (go-gitea#29690)
  Suppress error from monaco-editor (go-gitea#29684)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yardenshoham @6543 @delvh @GiteaBot