Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix date rendering by adding <gitea-absolute-date> (#29725) #29747

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Fix date rendering by adding <gitea-absolute-date> (#29725) #29747

merged 1 commit into from
Mar 13, 2024

Conversation

GiteaBot
Copy link
Contributor

Backport #29725 by @silverwind

Alternative to: #29698
Fixes: #29034

image

It also fixes a secondary issue that we were showing timestamp tooltips over date, which makes no sense, so these are now gone as well:

image

@silverwind @GiteaBot
Fix date rendering by adding <gitea-absolute-date> (go-gitea#29725)
436b608 
Alternative to: go-gitea#29698
Fixes: go-gitea#29034

<img width="278" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/12ecd967-2723-410d-8a28-a1b0f41b7bba">

It also fixes a secondary issue that we were showing timestamp tooltips
over date, which makes no sense, so these are now gone as well:

<img width="284" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/a70432f3-97b6-41e6-b202-b53b76924a66">
@GiteaBot GiteaBot added modifies/frontend modifies/go Pull requests that update Go code modifies/js modifies/templates This PR modifies the template files labels Mar 12, 2024
@GiteaBot GiteaBot added this to the 1.21.8 milestone Mar 12, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 12, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 12, 2024
@github-actions github-actions bot removed the modifies/templates This PR modifies the template files label Mar 12, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 12, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 13, 2024
@silverwind silverwind merged commit 6124c78 into go-gitea:release/v1.21 Mar 13, 2024
27 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@denyskon denyskon denyskon approved these changes

@yardenshoham yardenshoham Awaiting requested review from yardenshoham

Assignees

@silverwind silverwind

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/js size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.21.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GiteaBot @silverwind @denyskon