Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid jQuery AJAX #29818

Merged
merged 3 commits into from Mar 16, 2024
Merged

Forbid jQuery AJAX #29818

merged 3 commits into from Mar 16, 2024

Conversation

yardenshoham
Copy link
Member

Please use the fetch wrapper instead, or even better htmx.

@yardenshoham
Forbid jQuery AJAX
c7728f7 
Please use the fetch wrapper instead, or even better `htmx`.

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 15, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 15, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 15, 2024
@silverwind
Copy link
Member

Depends on the remaining Ajax PRs.

@yardenshoham
Copy link
Member Author

Thanks for the help reviewers! The work to remove jQuery is not done but this is a nice milestone to achieve.

@silverwind
Copy link
Member

Indeed, I've been meaning to do this for a long time, good that you picked it up. One step closer to being jQuery-free.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 15, 2024
techknowlogick
techknowlogick approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@silverwind silverwind enabled auto-merge (squash) March 16, 2024 01:58
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 16, 2024
@silverwind silverwind merged commit 6ead30d into go-gitea:main Mar 16, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 16, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 16, 2024
@yardenshoham yardenshoham deleted the forbid-jquery-ajax branch March 16, 2024 07:31
@Snowiiii
Copy link

Can someone explain why we want to remove jQuery? Isn't it a popular library, Whats the Problem?

@silverwind
Copy link
Member

silverwind commented Mar 16, 2024 •
edited

Because of performance and because it's considered a legacy library because DOM APIs have caught up to make it unnecessary.

FWIW, GitHub has completed the same migration in 2018 already.

@6543
Copy link
Member

6543 commented Mar 16, 2024

Can someone explain why we want to remove jQuery? Isn't it a popular library, Whats the Problem?

https://youmightnotneedjquery.com/

@Snowiiii
Copy link

Because of performance and because it's considered a legacy library because DOM APIs have caught up to make it unnecessary.

FWIW, GitHub has completed the same migration in 2018 already.

Thanks just rad trough the github site was very informative, So when we approximately will complete the migration ?

@6543
Copy link
Member

6543 commented Mar 16, 2024

I would say as soon as the linter forbid all jquery 😆

-> no timeline just steady progress

@silverwind
Copy link
Member

The big problem is the fomantic ui dependency which needs to be ripped out first.

zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 16, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
49462d6 
* giteaofficial/main: (28 commits)
  Forbid jQuery `.prop` and fix related issues (go-gitea#29832)
  Fix wrong test for TestPullView_CodeOwner (go-gitea#29838)
  Forbid HTML injection using jQuery (go-gitea#29843)
  Meilisearch double quote on "match" query (go-gitea#29740)
  Forbid variables containing jQuery collections not having the `$` prefix (go-gitea#29839)
  Remove AddParamIfExist(AddParam) (go-gitea#29841)
  Refactor markdown attention render (go-gitea#29833)
  Refactor code_indexer to use an SearchOptions struct for PerformSearch (go-gitea#29724)
  Refactor AddParam to AddParamIfExist (go-gitea#29834)
  Forbid jQuery AJAX (go-gitea#29818)
  Remove jQuery AJAX from the notifications (go-gitea#29817)
  Light theme color enhancements (go-gitea#29830)
  Better highlighting of archved labels (go-gitea#29749)
  Remove the `time-since` class (go-gitea#29826)
  Remove jQuery AJAX from the project page (go-gitea#29814)
  Upgrade `htmx` to v1.9.11 (go-gitea#29821)
  Dark theme color enhancements (go-gitea#29822)
  Remove jQuery AJAX from the comment edit box (go-gitea#29812)
  Tweak labeler (go-gitea#29809)
  Fix `for` attribute not pointing to the ID of the color picker (go-gitea#29813)
  ...

# Conflicts:
#	routers/web/user/home.go
silverwind pushed a commit to silverwind/gitea that referenced this pull request Mar 17, 2024
@yardenshoham @6543 @silverwind
Forbid jQuery AJAX (go-gitea#29818)
bd660fc 
Please use the fetch wrapper instead, or even better `htmx`.

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: 6543 <6543@obermui.de>
@lunny lunny modified the milestones: 1.23.0, 1.22.0 Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

@6543 6543 6543 approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@yardenshoham @silverwind @Snowiiii @6543 @techknowlogick @delvh @lunny @GiteaBot