Small refactors in anchors.js (#29947) #30003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some minor refactors, remove unnecessary `:is` selector and move the `:target` check out of the function. Might as well backport for the rare browser that does not support `:is`.
GiteaBot
added
modifies/frontend
modifies/js
skip-changelog
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
silverwind
approved these changes
Mar 22, 2024
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Mar 22, 2024
GiteaBot
added
lgtm/done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #29947 by @silverwind
Some minor refactors, remove unnecessary
:isselector and move the:targetcheck out of the function. Might as well backport for the rare browser that does not support:is.