Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory usage improvements #3013

Merged
merged 3 commits into from Nov 29, 2017
Merged

Memory usage improvements #3013

merged 3 commits into from Nov 29, 2017

Conversation

mrexodia
Copy link
Contributor

@mrexodia mrexodia commented Nov 28, 2017 •
edited

related issue: #2669

closes #3011 (since that change is included in my vendor update)

@mrexodia
govendor update code.gitea.io/git
cd865cb 
Signed-off-by: Duncan Ogilvie <mr.exodia.tpodt@gmail.com>
@mrexodia
Greatly improve memory usage
bbeb44e 
Signed-off-by: Duncan Ogilvie <mr.exodia.tpodt@gmail.com>
@codecov-io
Copy link

codecov-io commented Nov 28, 2017 •
edited

Codecov Report

Merging #3013 into master will decrease coverage by 0.04%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3013      +/-   ##
==========================================
- Coverage   32.73%   32.68%   -0.05%     
==========================================
  Files         267      267              
  Lines       39189    39211      +22     
==========================================
- Hits        12828    12816      -12     
- Misses      24539    24572      +33     
- Partials     1822     1823       +1
Impacted Files Coverage Δ
routers/repo/issue.go 35.27% <0%> (-0.11%) ⬇️
modules/context/repo.go 59.57% <0%> (-0.36%) ⬇️
routers/repo/editor.go 29.46% <0%> (-0.25%) ⬇️
routers/repo/download.go 57.14% <100%> (+2.14%) ⬆️
routers/repo/view.go 25.41% <36.84%> (-0.19%) ⬇️
models/repo_indexer.go 45.54% <0%> (-6.44%) ⬇️
modules/indexer/repo.go 60.86% <0%> (-2.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ad4990...bbeb44e. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 28, 2017
@lafriks
Copy link
Member

lafriks commented Nov 28, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 28, 2017
@lafriks lafriks added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 28, 2017
@lafriks lafriks added this to the 1.4.0 milestone Nov 28, 2017
@lunny
Copy link
Member

lunny commented Nov 29, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 29, 2017
@lunny
Copy link
Member

lunny commented Nov 29, 2017

make L-G-T-M work

@lunny lunny merged commit 551f3cb into go-gitea:master Nov 29, 2017
@mrexodia mrexodia deleted the memory-usage-improvements branch November 29, 2017 02:28
lafriks pushed a commit to lafriks-fork/gitea that referenced this pull request Nov 29, 2017
@mrexodia @lafriks
Memory usage improvements (go-gitea#3013)
f4db4e2 
* govendor update code.gitea.io/git

Signed-off-by: Duncan Ogilvie <mr.exodia.tpodt@gmail.com>

* Greatly improve memory usage

Signed-off-by: Duncan Ogilvie <mr.exodia.tpodt@gmail.com>
lafriks pushed a commit to lafriks-fork/gitea that referenced this pull request Nov 29, 2017
@mrexodia @lafriks
Memory usage improvements (go-gitea#3013)
ca8a854 
* govendor update code.gitea.io/git

Signed-off-by: Duncan Ogilvie <mr.exodia.tpodt@gmail.com>

* Greatly improve memory usage

Signed-off-by: Duncan Ogilvie <mr.exodia.tpodt@gmail.com>
lafriks added a commit that referenced this pull request Nov 29, 2017
@lafriks
Memory usage improvements (#3013) (#3028)
8cdd5a3 
* govendor update code.gitea.io/git

Signed-off-by: Duncan Ogilvie <mr.exodia.tpodt@gmail.com>

* Greatly improve memory usage

Signed-off-by: Duncan Ogilvie <mr.exodia.tpodt@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mrexodia @codecov-io @lafriks @lunny @tboerger