Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missed doer #30231

Merged
merged 6 commits into from
Apr 8, 2024
Merged

Fix missed doer #30231

merged 6 commits into from
Apr 8, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 1, 2024

Fix #29879

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 1, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 1, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Apr 1, 2024
@lunny lunny added the type/bug label Apr 1, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 1, 2024
@lunny lunny added the backport/v1.22 This PR should be backported to Gitea 1.22 label Apr 7, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 7, 2024
@wxiaoguang wxiaoguang mentioned this pull request Apr 7, 2024
Open
@wxiaoguang
Copy link
Contributor

Overall LGTM, maybe it's better to leave it open for a few days before merge.

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 8, 2024
@silverwind silverwind enabled auto-merge (squash) April 8, 2024 14:16
@silverwind silverwind merged commit 908426a into go-gitea:main Apr 8, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 8, 2024
GiteaBot added a commit to GiteaBot/gitea that referenced this pull request Apr 8, 2024
@lunny @GiteaBot
Fix missed doer (go-gitea#30231)
95966f6 
Fix go-gitea#29879

Co-authored-by: Giteabot <teabot@gitea.io>
@GiteaBot GiteaBot mentioned this pull request Apr 8, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Apr 8, 2024
lafriks pushed a commit that referenced this pull request Apr 8, 2024
@GiteaBot @lunny
Fix missed doer (#30231) (#30343)
e0b9638 
Backport #30231 by @lunny

Fix #29879

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 9, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
d5add2e 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix missed doer (go-gitea#30231)
  Add optional doctor storage init (go-gitea#30330)
  Avoid running action when action unit is disabled after workflows detected (go-gitea#30331)
  Avoid showing `Failed to change the default wiki branch` if repo has no wiki when saving repo settings (go-gitea#30329)
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 27, 2024
@yp05327 yp05327 mentioned this pull request May 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Gitea hides user email in PR API
4 participants
@lunny @wxiaoguang @silverwind @GiteaBot