Fix missing 0 prefix of GPG key id (#30245) #30247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes go-gitea#30235 If the key id "front" byte has a single digit, `%X` is missing the 0 prefix. ` 38D1A3EADDBEA9C` instead of `038D1A3EADDBEA9C` When using the `IssuerFingerprint` slice `%X` is enough but I changed it to `%016X` too to be consistent.
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
KN4CK3R
approved these changes
Apr 2, 2024
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Apr 2, 2024
GiteaBot
added
lgtm/done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #30245 by @KN4CK3R
Fixes #30235
If the key id "front" byte has a single digit,
%Xis missing the 0 prefix.38D1A3EADDBEA9Cinstead of038D1A3EADDBEA9CWhen using the
IssuerFingerprintslice%Xis enough but I changed it to%016Xtoo to be consistent.