Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent automatic OAuth grants for public clients #30790

Merged
merged 3 commits into from
May 2, 2024
Merged

Prevent automatic OAuth grants for public clients #30790

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8bc0f8
Prevent automatic OAuth grants for public clients
archer-321 Apr 30, 2024
586e645
Merge branch 'main' into always-require-auth-for-public-oauth-clients
wxiaoguang May 2, 2024
f7a8a1a
Merge branch 'main' into always-require-auth-for-public-oauth-clients
GiteaBot May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions routers/web/auth/oauth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,8 +470,9 @@ func AuthorizeOAuth(ctx *context.Context) {
return
}

// Redirect if user already granted access
if grant != nil {
// Redirect if user already granted access and the application is confidential.
// I.e. always require authorization for public clients as recommended by RFC 6749 Section 10.2
if app.ConfidentialClient && grant != nil {
code, err := grant.GenerateNewAuthorizationCode(ctx, form.RedirectURI, form.CodeChallenge, form.CodeChallengeMethod)
if err != nil {
handleServerError(ctx, form.State, form.RedirectURI)
Expand Down