Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return access_denied error when an OAuth2 request is denied (#30974) #31029

Merged
merged 2 commits into from
May 20, 2024
Merged

Return access_denied error when an OAuth2 request is denied (#30974) #31029

merged 2 commits into from
May 20, 2024

Commits on May 20, 2024

  1. Return access_denied error when an OAuth2 request is denied (go-git… 

    …ea#30974)

According to [RFC
6749](https://datatracker.ietf.org/doc/html/rfc6749#section-4.1.2.1),
when the resource owner or authorization server denied an request, an
`access_denied` error should be returned. But currently in this case
Gitea does not return any error.

For example, if the user clicks "Cancel" here, an `access_denied` error
should be returned.

<img width="360px"
src="https://github.com/go-gitea/gitea/assets/15528715/be31c09b-4c0a-4701-b7a4-f54b8fe3a6c5"
/>
    @Zettat123 @GiteaBot
    Zettat123 authored and GiteaBot committed May 20, 2024
    Configuration menu
    Copy the full SHA
    e7cbf2b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release/v1.22' into backport-30974-v1.22

    @KN4CK3R
    KN4CK3R committed May 20, 2024
    Configuration menu
    Copy the full SHA
    8e9136e View commit details
    Browse the repository at this point in the history