Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use existing oauth grant for public client (#31015) #31041

Merged
merged 1 commit into from
May 21, 2024

Conversation

GiteaBot
Copy link
Contributor

Backport #31015 by @denyskon

Do not try to create a new authorization grant when one exists already, thus preventing a DB-related authorization issue.

Fix #30790 (comment)

Do not try to create a new authorization grant when one exists already,
thus preventing a DB-related authorization issue.

Fix go-gitea#30790 (comment)

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@GiteaBot GiteaBot added modifies/go Pull requests that update Go code topic/authentication type/bug labels May 21, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 21, 2024
@GiteaBot GiteaBot added this to the 1.21.12 milestone May 21, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 21, 2024
@GiteaBot GiteaBot requested review from delvh and wxiaoguang May 21, 2024 16:23
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 21, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 21, 2024
@lunny lunny enabled auto-merge (squash) May 21, 2024 16:37
@lunny lunny merged commit ec4fa23 into go-gitea:release/v1.21 May 21, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/authentication type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants