Update alpine to 3.7

[sapk]

Alpine 3.7 has been release 😄

[ethantkoenig]

LGTM (CI failure seems unrelated)

[0rzech]

Golang based on Alpine 3.7 is still in beta. Maybe it would be better to wait for its release, so the same version of Alpine is used for compilation and deployment?

[sapk]

That go1.10 that is in beta but alpine 3.7 does have go1.9 as golang version and we don't even have go inside the final docker container.

[0rzech]

Sorry, the golang image itself is rc, not beta.

Official Golang Docker images do not use Go from Alpine repositories (though there is Go 1.9 in Alpine 3.7 community repo) and yes, we do not have Go installed in deployment image, but we do use specific Go version and link to system libraries when building Gitea in build image.

Btw. This is one of the reasons for Docker's existence: to minimize differences between development and production environments. Also, Alpine 3.7 is absolutely brand new, so maybe it would be better to let it settle a bit?

Maybe it's nothing, but IMHO there's no reason to pursue novelty yet. Especially when there's #2927 just around the corner.

Just my $0.02. I'm not blocking anything. ;)

[sapk]

@0rzech I understand and I will update #2927 accordingly. ;-)

edit: or the opposite if #2927 is merge before XD

[techknowlogick]

LGTM

[codecov-io]

Codecov Report

Merging #3121 into master will increase coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3121      +/-   ##
==========================================
+ Coverage   34.62%   34.85%   +0.22%     
==========================================
  Files         274      274              
  Lines       40026    40026              
==========================================
+ Hits        13861    13952      +91     
+ Misses      24183    24075     -108     
- Partials     1982     1999      +17

Impacted Files	Coverage Δ
models/repo.go	41.47% <0%> (+0.18%)	⬆️
models/repo_list.go	67.18% <0%> (+1.56%)	⬆️
models/repo_indexer.go	51.45% <0%> (+2.91%)	⬆️
models/lfs.go	31.25% <0%> (+6.25%)	⬆️
modules/lfs/server.go	35.01% <0%> (+14.32%)	⬆️
modules/lfs/content_store.go	43.75% <0%> (+35.93%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8e45b1...4d0f81e. Read the comment docs.

[sapk]

Rebase and now tests are passing. \o/
Ready to be merge.