New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the default action for the gitea executable that of running the webserver #3331

Merged
merged 4 commits into from Jan 10, 2018

Conversation

9 participants
@thehowl
Member

thehowl commented Jan 8, 2018

Pretty simple. Since most gitea users won't ever need to touch any of the other functions, I see no need in requiring calling the web subcommand to run the webserver - thus I propose as a default action for the gitea command that of running the webserver.

@codecov-io

This comment has been minimized.

codecov-io commented Jan 8, 2018

Codecov Report

Merging #3331 into master will decrease coverage by 0.2%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3331      +/-   ##
==========================================
- Coverage   35.05%   34.85%   -0.21%     
==========================================
  Files         280      280              
  Lines       40556    40559       +3     
==========================================
- Hits        14216    14135      -81     
- Misses      24236    24336     +100     
+ Partials     2104     2088      -16
Impacted Files Coverage Δ
main.go 24.13% <0%> (-2.79%) ⬇️
modules/lfs/content_store.go 7.81% <0%> (-35.94%) ⬇️
modules/lfs/server.go 20.68% <0%> (-14.33%) ⬇️
modules/indexer/indexer.go 70% <0%> (-7.5%) ⬇️
models/lfs.go 26.08% <0%> (-2.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5fba4c...61ec48a. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 label Jan 8, 2018

@strk

This comment has been minimized.

Member

strk commented Jan 8, 2018

LGTM although I don't really feel a need for this (but I'm not against if you do)

@tboerger tboerger added lgtm/need 1 and removed lgtm/need 2 labels Jan 8, 2018

@thehowl

This comment has been minimized.

Member

thehowl commented Jan 8, 2018

This is really a proposal rather than a PR - I'd really love to hear everyone's take on this even just as a +1/-1 on the OP. I think it improves usability by first-timers, of course there is no need for this, it's just a quality-of-life thing :)

@lafriks

This comment has been minimized.

Member

lafriks commented Jan 8, 2018

I do better like that it prints help by default but that just my preference

@bkcsoft

This comment has been minimized.

Member

bkcsoft commented Jan 8, 2018

Yes Please. LGTM 🎉

@tboerger tboerger added lgtm/done and removed lgtm/need 1 labels Jan 8, 2018

@appleboy

This comment has been minimized.

Member

appleboy commented Jan 9, 2018

maybe we should update the document.

@lunny lunny added this to the 1.4.0 milestone Jan 9, 2018

@sapk

This comment has been minimized.

Member

sapk commented Jan 9, 2018

Not really in favor but not against and you have at least two LGTM.
But doesn't this also means that you can't use web command flags (-p -c -P) with the default ./gitea?

@thehowl

This comment has been minimized.

Member

thehowl commented Jan 9, 2018

But doesn't this also means that you can't use web command flags (-p -c -P) with the default ./gitea?

Yes, that is intended. I don't want to create confusion among the users about where the web command flags can be used (e.g. one might think that they also apply to all other subcommands), so unless web is specified no other flags will be accepted.

FWIW, this paradigm is also present in git itself: git stash will by default run git stash push with no other arguments; if you want to provide them, you'll have to specify push, e.g. git stash push -m 'Thing' will work, whereas git stash -m 'Thing' will not

@sapk

This comment has been minimized.

Member

sapk commented Jan 9, 2018

@thehowl thanks for the details.

@lafriks lafriks merged commit 88a3bb6 into go-gitea:master Jan 10, 2018

3 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

aswild added a commit to aswild/gitea that referenced this pull request Feb 25, 2018

Revert "Make the default action for the gitea executable that of runn…
…ing the webserver (go-gitea#3331)"

I don't actually like this feature, since starting the web server with
a default config creates a bunch of install files

This reverts commit 88a3bb6.

aswild added a commit to aswild/gitea that referenced this pull request Apr 14, 2018

Revert "Make the default action for the gitea executable that of runn…
…ing the webserver (go-gitea#3331)"

I don't actually like this feature, since starting the web server with
a default config creates a bunch of install files

This reverts commit 88a3bb6.

aswild added a commit to aswild/gitea that referenced this pull request Apr 14, 2018

Revert "Make the default action for the gitea executable that of runn…
…ing the webserver (go-gitea#3331)"

I don't actually like this feature, since starting the web server with
a default config creates a bunch of install files

This reverts commit 88a3bb6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment