Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using maintained spdx license list #3484

Merged
merged 2 commits into from
Feb 12, 2018
Merged

Conversation

jonasfranz
Copy link
Member

The currently used license repository https://github.com/spdx/license-list is not longer maintained because it is replaced by https://github.com/spdx/license-list-data. (See #3475 (comment))

This PR uses the new repository by deleting the old licenses and replacing them with the new ones from license-list-data. It also updates the generate-licences.go file by using the new repository.

This is WIP because it is not clear to me if this PR is "breaking" because the old licenses are not longer available by default.

…itory.

Signed-off-by: Jonas Franz <info@jonasfranz.software>
@codecov-io
Copy link

codecov-io commented Feb 10, 2018

Codecov Report

Merging #3484 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3484      +/-   ##
==========================================
- Coverage   35.68%   35.67%   -0.01%     
==========================================
  Files         281      281              
  Lines       40697    40697              
==========================================
- Hits        14522    14520       -2     
- Misses      24027    24029       +2     
  Partials     2148     2148
Impacted Files Coverage Δ
models/repo_list.go 65.62% <0%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cb4649...434d034. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 10, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 11, 2018
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 12, 2018
@jonasfranz jonasfranz changed the title [WIP] Using maintained spdx license list Using maintained spdx license list Feb 12, 2018
@lafriks lafriks added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 12, 2018
@lafriks lafriks added this to the 1.5.0 milestone Feb 12, 2018
@lafriks lafriks merged commit fbdc00f into go-gitea:master Feb 12, 2018
@jonasfranz jonasfranz mentioned this pull request Feb 12, 2018
@jonasfranz jonasfranz deleted the new-licenses branch February 12, 2018 19:40
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants